-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout Sections and Profiles #363
Conversation
…p for update hook
…ection with new page meta block
… for two column layouts
…updated permissions for profiles
…-project into YALB-85-profiles
Created multidev environment pr-363 for yalesites-platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!!!!! Nice job!!!!!
@joetower I would say probably no for quick links. I added one and it doesn't look like it could fit even with some changes. Looking at the rest of the list, I feel like the rest of the blocks should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codechefmarc I confirmed that the options for two-column layout primary region now include those outlined in the theming ticket. That looks great, thanks!
I pushed up a fix to the atomic branch for the profile breadcrumbs and left a note in that PR. Please give my change a look. Otherwise this is looking good to me!
…s for regular sections
Quick bug found: I added a second contact info block in the right side, then tried to remove that block (or even the original one) and they cannot be deleted. |
Great find @miketullo95! I've fixed that issue and it's on the multidev. |
@codechefmarc @miketullo95 I pushed a fix to this branch (in Atomic) for the section visual borders. If you test on this multidev: https://pr-363-yalesites-platform.pantheonsite.io and login and edit this example Profile: https://pr-363-yalesites-platform.pantheonsite.io/node/98/layout, you should see the following: yalb-node-section-borders.mp4Please let me know what you think Mike. 👍 |
@joetower - That looks really nice! |
@joetower agree with marc, this looks great! Quick question, the admin styles for the tabs in /edit on a profile needs updating. Is that suitable for this PR or your other open PR for admin fixes? |
@miketullo95 I pushed a fix for that in a related branch here: #371 (comment) Please take a look at that comment and let me know what your thoughts are. Thank you! |
oooh, i see! apologies, both look great! 👍 |
Tickets
Description of work
Functional testing steps:
Pages
Events
Posts
Profiles